lkml.org 
[lkml]   [2008]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mach_reboot_fixups()

* Jan Beulich <jbeulich@novell.com> wrote:

> Not exactly - when rebooting through EFI or BIOS, the old code didn't
> go through mach_reboot_fixups(), and I think that is the correct
> behavior (albeit, when the EFI path fell back to the triple fault
> mechanism, it should have honored the fixup logic, and I think it is
> more correct that the new code tries the keyboard method first).
> Perhaps the most reasonable way to go is to honor all reboot= settings
> without using the override code first:

> case BOOT_KBD:
> + mach_reboot_fixups(); /* for board specific fixups */

ok, agreed.

> (with the exception that reboot=keyboard will still have the effect of
> honoring the fixups, but I think this is better than further
> complicating the logic).

the fixups are really "emergency exceptions" - for (a very low number
of) broken boards that just cannot reboot via the default BOOT_KBD
method. In that sense it's a small detail how widely we apply the
exceptions - those boards probably wont be rebooted via reboot=bios
[people only use reboot options when they have trouble rebooting].

> In case you want to take this,
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

i modified the patch and added your signoff - thanks,

Ingo


\
 
 \ /
  Last update: 2008-03-07 09:27    [W:0.089 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site