Messages in this thread | | | From | David Brownell <> | Subject | Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI | Date | Fri, 7 Mar 2008 17:13:57 -0800 |
| |
On Thursday 06 March 2008, Liam Girdwood wrote:
> +What: /sys/class/regulator/.../microvolts > + ... > + > +What: /sys/class/regulator/.../microamps > + ...
Versus Documentation/hwmon/sysfs-interface which uses millivolts and milliamperes respectively.
Why not adopt the same convention? (This applies to many attributes, not just these two.)
Also, I'm kind of curious what you've thought about power budgeting. Example, a power supply ("regulator") may be able to supply a voltage within a given range, but only up to a maximum of 200 mA worth.
The model visible through these sysfs attributes seems to be an either/or thing ... either regulating voltage, or current, but not addressing the corresponding constraints on the other one.
> + NOTE: this will return the string 'constraint not defined'
How about just "undefined" for all those min/max values?
> +What: /sys/class/regulator/.../requested_microamps > + ...
Ditto re "milli" vs "micro". Also, "requested" seems a bit opaque. As a sum, maybe "total_mi{lli,cro}amps" would be more explanatory.
- Dave
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |