Messages in this thread Patch in this message | | | Date | Fri, 7 Mar 2008 12:42:03 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH -v8b -rc3] Security: Introduce security= boot parameter |
| |
On Thu, 6 Mar 2008, Ahmed S. Darwish wrote:
> + * Each LSM must pass this method before registering its own operations > + * to avoid security registration races. This method may also be used > + * to check if your LSM is currently loaded.
The 2nd sentence is no longer correct in general, as the function can only be called during init. See a fixup patch below.
Otherwise, looks good!
Acked-by: James Morris <jmorris@namei.org>
I've applied the patch and a comment fixup to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6.git#next
commit d6bb3bacedb68aa41ea7598e0cf1bef33cebbcc9 Author: James Morris <jmorris@namei.org> Date: Fri Mar 7 12:23:49 2008 +1100
security: fix up documentation for security_module_enable
security_module_enable() can only be called during kernel init.
Signed-off-by: James Morris <jmorris@namei.org>
diff --git a/security/security.c b/security/security.c index 4377b00..8aa2f54 100644 --- a/security/security.c +++ b/security/security.c @@ -83,7 +83,7 @@ __setup("security=", choose_lsm); * * Each LSM must pass this method before registering its own operations * to avoid security registration races. This method may also be used - * to check if your LSM is currently loaded. + * to check if your LSM is currently loaded during kernel initialization. * * Return true if: * -The passed LSM is the one chosen by user at boot time,
-- James Morris <jmorris@namei.org>
| |