lkml.org 
[lkml]   [2008]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Linux-fbdev-devel] [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors
On Sun, 27 Jan 2008 12:34:56 +0100 Michal Januszewski <spock@gentoo.org> wrote:

> From: Michal Januszewski <spock@gentoo.org>
>
> Don't treat valid modes returned by fb_find_mode() (best-fit modes,
> default modes or the first valid mode) as errors.
>

This changelog is too brief.

> ---
> diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
> index a14ef89..fc68b3e 100644
> --- a/drivers/video/uvesafb.c
> +++ b/drivers/video/uvesafb.c
> @@ -885,7 +885,7 @@ static int __devinit uvesafb_vbe_init_mode(struct fb_info *info)
> }
>
> /* fb_find_mode() failed */
> - if (i == 0 || i >= 3) {
> + if (i == 0) {
> info->var.xres = 640;
> info->var.yres = 480;
> mode = (struct fb_videomode *)
>

Because I cannot tell what are the consequences of the bug which you're
fixing, hence I cannot tell whether we need this fix in 2.6.25 or even
2.6.24.



\
 
 \ /
  Last update: 2008-03-06 07:57    [W:1.542 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site