Messages in this thread | | | Date | Wed, 5 Mar 2008 22:54:12 -0800 | From | Andrew Morton <> | Subject | Re: [Linux-fbdev-devel] [PATCH] uvesafb: don't treat valid modes returned by fb_find_mode() as errors |
| |
On Sun, 27 Jan 2008 12:34:56 +0100 Michal Januszewski <spock@gentoo.org> wrote:
> From: Michal Januszewski <spock@gentoo.org> > > Don't treat valid modes returned by fb_find_mode() (best-fit modes, > default modes or the first valid mode) as errors. >
This changelog is too brief.
> --- > diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c > index a14ef89..fc68b3e 100644 > --- a/drivers/video/uvesafb.c > +++ b/drivers/video/uvesafb.c > @@ -885,7 +885,7 @@ static int __devinit uvesafb_vbe_init_mode(struct fb_info *info) > } > > /* fb_find_mode() failed */ > - if (i == 0 || i >= 3) { > + if (i == 0) { > info->var.xres = 640; > info->var.yres = 480; > mode = (struct fb_videomode *) >
Because I cannot tell what are the consequences of the bug which you're fixing, hence I cannot tell whether we need this fix in 2.6.25 or even 2.6.24.
| |