lkml.org 
[lkml]   [2008]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] chroot= as a new kernel parameter
Date
Guillaume Chazarain <guichaz@gmail.com> wrote:
> On Wed, Mar 5, 2008 at 2:38 PM, Pawel Plociennik <paplociennik@gmail.com>

>> At last my patch is as simple as possible and it has *only* a *few lines of
>> the code* and it can be used as *independent* method to various *hundred*
>> distroes.
>
> Your method requires a certain kernel, mine does not ;-)

Your method requires to type the whole bible on the command line.

>> static void run_init_process(char *init_filename)
>> {
>> + if (chroot_str)
>> + if (sys_chroot(chroot_str) < 0)
>> + printk(KERN_WARNING "chroot=%s failed\n",
>> chroot_str); +
>
> As I said before, this chroot= option can be used for security reason
> instead of testing purpose, and in this case, continuing booting after
> a failed chroot sounds like a security issue.

Even if not, continuing on unknown/bad options is a BAD idea. If I made a
typo in the path, the wrong system would be started, leaving me to choose
between waiting (felt) five minutes until I can shut it down cleanly or
to hard reboot and fsck.



\
 
 \ /
  Last update: 2008-03-06 01:19    [W:0.024 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site