lkml.org 
[lkml]   [2008]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and &
    From
    Date
    On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote:
    > * Christopher Li <sparse@chrisli.org> wrote:
    >
    > > I think Al Viro has sent a patch to linux-sparse with subject "[PATCH
    > > 3/3] catch !x & y brainos" does exactly that.
    >
    > ah - nice :-)
    >
    > /me checks the linux-sparse archive
    >
    > Al's patch is:
    >
    > + if (op == '&' && expr->left->type == EXPR_PREOP &&
    > + expr->left->op == '!')
    > + warning(expr->pos, "dubious: !x & y");
    >
    > i think there might be similar patterns: "x & !y", "!x | y", "x | !y" ?
    >

    Well, (!x & y) and (!x | y) are probably the two that might have been
    intended otherwise. (x & !y), (x | !y) are probably ok.

    Harvey



    \
     
     \ /
      Last update: 2008-03-05 08:13    [W:0.049 / U:0.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site