lkml.org 
[lkml]   [2008]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mvsas: fill in error info record bits
Roel Kluin wrote:
> Jeff Garzik wrote:
>> This describes the first dword of struct mvs_err_info, two-dword error
>> information record that is returned when RXQ_ERR bit is asserted.
>>
>> These bits are necessary for proper error handling.
>>
>> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
>> ---
>> diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
>> index d4a6ac3..ec4dda0 100644
>> --- a/drivers/scsi/mvsas.c
>> +++ b/drivers/scsi/mvsas.c
>> @@ -511,7 +511,35 @@ enum status_buffer {
>> };
>>
>> enum error_info_rec {
>> - CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
>> + CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
>> + CMD_PI_ERR = (1U << 30), /* Protection info error. see flags2 */
>> + RSP_OVER = (1U << 29), /* rsp buffer overflow */
>> + RETRY_LIM = (1U << 28), /* FIS/frame retry limit exceeded */
>> + UNK_FIS = (1U << 27), /* unknown FIS */
>> + DMA_TERM = (1U << 26), /* DMA terminate primitive rx'd */
>> + SYNC_ERR = (1U << 25), /* SYNC rx'd during frame xmit */
>> + TFILE_ERR = (1U << 24), /* SATA taskfile Error bit set */
>> + R_ERR = (1U << 23), /* SATA returned R_ERR prim */
>> + RD_OFS = (1U << 20), /* Read DATA frame invalid offset *?
>
> there is a question mark instead of a slash in the line above.

definitely a mistake


> also I noted 1U << 22 to 1U << 21 were missing. was that intended?

yes, intended

Jeff




\
 
 \ /
  Last update: 2008-03-05 20:49    [W:0.062 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site