lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: WARNING: at drivers/usb/host/ehci-hcd.c:287
Date
On Tuesday 04 March 2008, Christian Kujau wrote:
> On Tue, 4 Mar 2008, David Brownell wrote:
> >>> Or bettter yet, just removing it entirely. ISTR doing that in some
> >>> patches I've not yet sent for merging, and expect that's what my
> >>> preferred fix will be ...
> >>
> >> But removing the WARN_ON won't fix the problem.
> >
> > It fully resolves the $SUBJECT problem. :)
>
> ...and if it's a safe thing to do, I'm happy with it. I really have no
> clue why shutting up a WARN_ON has no (future) implications but if you
> say so I trust you :)

Carrying that WARN_ON forward was inappropriate, so
removing it is a safe thing to do.

There are other lurking issues though.

- Dave


\
 
 \ /
  Last update: 2008-03-05 01:33    [W:0.054 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site