lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: WARNING: at drivers/usb/host/ehci-hcd.c:287
    On Tue, 4 Mar 2008, David Brownell wrote:

    > On Tuesday 04 March 2008, Alan Stern wrote:
    > > Dave, it seems to me that this must be an example of a race between the
    > > iaa watchdog timer expiring and end_unlink_async() running.  It's not
    > > good enough for end_unlink_async() to call iaa_watchdog_done(), because
    > > on an SMP system the timer may already have fired and the watchdog
    > > routine may be spinning on ehci->lock.
    >
    > Right.
    >
    >
    > > How about replacing the
    > >
    > >         WARN_ON(!ehci->reclaim);
    >
    > Or bettter yet, just removing it entirely. ISTR doing that in some
    > patches I've not yet sent for merging, and expect that's what my
    > preferred fix will be ...

    But removing the WARN_ON won't fix the problem. The routine still
    needs to exit immediately if ehci->reclaim isn't set, the root hub
    isn't running, or the timer has been restarted.

    Alan Stern

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-03-04 22:01    [W:0.043 / U:0.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site