Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH 4/4] ACPI PCI slot detection driver | Date | Tue, 4 Mar 2008 12:02:09 -0800 |
| |
On Tuesday, March 04, 2008 11:30 am Greg KH wrote: > bad data is worse.
But we don't want to throw the baby out with the bathwater; assuming there are lots of machines out there with good data (I really hope that's the case), this feature seems like a really good idea.
> And then there's the machines with duplicate slot names, how does this > code handle PCI slots with that? I think some of the IBM machines had > non-hotplug slots named the same as the hotplug slots, right? > > This stuff needs a _lot_ of testing on a lot of different machines, and > a sane way to fall-back if there are errors to ensure that working > machines don't break.
Yeah, I think a good fallback is important. Might be good to have a blacklist along with a heuristic for detecting duplicate slot names... Anyway, yeah, testing will be huge here.
Jesse
| |