Messages in this thread | | | Date | Tue, 4 Mar 2008 10:19:31 -0800 | From | "Adam J. Richter" <> | Subject | Re: Patch: romfs_lookup always failed in linux-2.6.25-rc3-git3 |
| |
On Tue, Mar 04, 2008 at 01:26:21AM -0800, Andrew Morton wrote: > On Mon, 3 Mar 2008 09:36:20 -0800 "Adam J. Richter" <adam@yggdrasil.com> wrote: [...] > > P.S. romfs_lookup casts a valid pointer to an int and then back again > > with res = PTR_ERR(inode);...return ERR_PTR(res). This may break on > > arhictectures where sizeof(int) < sizeof(pointer). If I want to submit > > a subsequent fix for this, are you the person I should the patch to?
Oops, please ignore my incorrect "P.S.". As David Howells has explained, the PTR_ERR(inode) call is only done when inode is known to contain an error code, so it should be safe on all architectures.
Sorry for the false alarm about that part.
Adam
| |