lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/14] drivers/s390: replace remaining __FUNCTION__ occurrences
On Tue, 04 Mar 2008 09:55:07 +0100 Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:

> On Mon, 2008-03-03 at 19:09 -0800, Harvey Harrison wrote:
> > __FUNCTION__ is gcc-specific, use __func__
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > drivers/s390/block/dasd.c | 4 +-
> > drivers/s390/char/tape_34xx.c | 2 +-
> > drivers/s390/char/vmwatchdog.c | 4 +-
> > drivers/s390/char/zcore.c | 2 +-
> > drivers/s390/cio/device_status.c | 2 +-
> > drivers/s390/crypto/zcrypt_api.h | 8 +-
> > drivers/s390/net/claw.c | 344 +++++++++++++++++++-------------------
> > drivers/s390/net/ctcmain.c | 112 ++++++------
> > drivers/s390/net/netiucv.c | 96 ++++++------
> > drivers/s390/s390mach.c | 8 +-
> > drivers/s390/scsi/zfcp_def.h | 2 +-
> > 11 files changed, 292 insertions(+), 292 deletions(-)
>
> Urgh, is this really necessary? The linux kernel is always compiled with
> gcc for s390. Yes __func__ is a bit shorter and maybe even looks nicer
> than __FUNCTION__ but is it really worth the trouble ?
>

That's what everyone is asking ;)

Unfortunately, __func__ is preferred and __FUNCTION__ is deprecated. So
the patch converts your code from "wrong" to "right". Even though it was
only a teeny bit wrong.



\
 
 \ /
  Last update: 2008-03-04 10:19    [W:2.054 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site