Messages in this thread | | | Subject | Re: [2.6 patch] mm/page_alloc.c: cleanups | From | Peter Zijlstra <> | Date | Mon, 31 Mar 2008 13:32:18 +0200 |
| |
On Mon, 2008-03-31 at 01:53 +0300, Adrian Bunk wrote: > This patch contains the following cleanups: > - make the following needlessly global variables static: > - required_kernelcore > - zone_movable_pfn[] > - make the following needlessly global functions static: > - move_freepages() > - move_freepages_block() > - setup_pageset() > - find_usable_zone_for_movable() > - adjust_zone_range_for_zone_movable() > - __absent_pages_in_range() > - find_min_pfn_for_node() > - find_zone_movable_pfns_for_nodes() > - #if 0 the following no longer used global function: > - free_cold_page()
Why no outright removal? #if 0 only leaves more junk around to clean up later.
| |