Messages in this thread | | | Date | Mon, 31 Mar 2008 09:40:03 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 5/7] lxfb: add power management functionality |
| |
Hi!
> +static int lxfb_suspend(struct pci_dev *pdev, pm_message_t state) > +{ > + struct fb_info *info = pci_get_drvdata(pdev); > + > + if (pdev->dev.power.power_state.event == state.event) > + return 0;
This should never trigger. See Doc*/feature-removal-sch*.
> + /* there's no point in setting PCI states; we emulate PCI, so > + * we don't end up getting power savings anyways */ > + > + pdev->dev.power.power_state = state;
And there's no point doing this.
> + pdev->dev.power.power_state = PMSG_ON;
Or this.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |