lkml.org 
[lkml]   [2008]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] evdev: Release eventual input device grabs when getting disconnected


On Mon, 31 Mar 2008, Dmitry Torokhov wrote:
>
> Greg, please look at the change again. Before kobject_put(kobj->parent)
> was done in kobject_cleanup() and so the parent would only be freed when
> all its children are gone. Now parent is deleted early, even if its
> children are still referenced by other users. This is lifetime rule
> change and should really be announced as such.
>
> If this change it intentional and is here to stay then I will just grab
> the references myself, although I wonder what else might be broken by
> it.

I do agree that this might want reverting, unless there is some rally good
reason for it. People may have pefectly valid reasons to expect topology
and reachability to remain valid - it's certainly what we guarantee in the
VFS code for similar rules (ie the parent of a dentry is only free'd after
all children have gone away).

Greg, is it possible to get the old lifetime rules back wrt his? They seem
valid and sane..

Linus


\
 
 \ /
  Last update: 2008-03-31 20:29    [W:0.872 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site