lkml.org 
[lkml]   [2008]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: create array based interface to change page attribute
On Mon, Mar 31, 2008 at 09:21:19PM +1000, Dave Airlie wrote:
> On Mon, Mar 31, 2008 at 5:25 PM, Andi Kleen <andi@firstfloor.org> wrote:
> > Dave Airlie <airlied@redhat.com> writes:
> > >
> > > +#define CPA_FLUSHTLB 1
> > > +#define CPA_ARRAY 2
> >
> > I don't think CPA_ARRAY should be a separate case. Rather single
> > page flushing should be an array with only a single entry. pageattr
> > is already very complex, no need to make add more special cases.
>
> I thought about this but the current interface takes a start address
> and number of pages from that point to cpa,
> the array interface takes an array of page sized pages.
>
> I don't really think we need to generate an array in the first case
> with all the pages in it..

Just put the length into the array members too.

-Andi


\
 
 \ /
  Last update: 2008-03-31 13:45    [W:0.059 / U:17.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site