lkml.org 
[lkml]   [2008]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data
Huang wrote:
> +/* setup data types */
> +#define SETUP_NONE 0

This define seems unused?

Actually, what use would it ever have? Should not every
struct setup_data on the setup_data linked list have a
valid (not NONE) type? And perhaps that switch statement
that confused me:

> + switch (data->type) {
> + default:
> + break;
> + }

should not "break" silently on an unrecognized data->type, but
rather complain bitterly?

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214


\
 
 \ /
  Last update: 2008-03-30 06:35    [W:0.136 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site