Messages in this thread | | | Date | Sat, 29 Mar 2008 23:31:55 -0500 | From | Paul Jackson <> | Subject | Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data |
| |
Huang wrote: > +/* setup data types */ > +#define SETUP_NONE 0
This define seems unused?
Actually, what use would it ever have? Should not every struct setup_data on the setup_data linked list have a valid (not NONE) type? And perhaps that switch statement that confused me:
> + switch (data->type) { > + default: > + break; > + }
should not "break" silently on an unrecognized data->type, but rather complain bitterly?
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214
| |