Messages in this thread | | | Date | Mon, 3 Mar 2008 13:57:42 -0500 | From | Rik van Riel <> | Subject | Re: [patch 02/21] Use an indexed array for LRU variables |
| |
On Fri, 29 Feb 2008 16:03:20 +0000 Andy Whitcroft <apw@shadowen.org> wrote:
> > /* First 128 byte cacheline (assuming 64 bit words) */ > > NR_FREE_PAGES, > > - NR_INACTIVE, > > - NR_ACTIVE, > > + NR_INACTIVE, /* must match order of LRU_[IN]ACTIVE */ > > + NR_ACTIVE, /* " " " " " */ > > This little ordering constraint is a little nasty. If we have enum_list > available at this point then we can make sure that these order correctly > automatically with something like this:
A little, true.
However, we need to line up with vmstat_text as well, so I suspect the best way to make this friendlier to people new to this part of the kernel would be to add more documentation, not more magic.
-- All Rights Reversed
| |