Messages in this thread |  | | Date | Sat, 29 Mar 2008 13:38:20 +0900 | | From | KAMEZAWA Hiroyuki <> | | Subject | Re: [PATCH RFC] hotplug-memory: refactor online_pages to separate zone growth from page onlining |
| |
Hi,
On Fri, 28 Mar 2008 17:00:05 -0700 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> - if (onlined_pages) > + if (onlined_pages) { > + struct memory_notify arg; > + > + arg.start_pfn = pfn; /* ? */ > + arg.nr_pages = onlined_pages; > + arg.status_change_nid = -1; /* ? */ > + > memory_notify(MEM_ONLINE, &arg); > + } I think you should add "onlined" member instead of reusing nr_pages.
But, in general, I have no objection to this way.
Thanks, -Kame
|  |