lkml.org 
[lkml]   [2008]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2 of 4] hotplug-memory: adding non-section-aligned memory is bad
    KAMEZAWA Hiroyuki wrote:
    > For example, mem_notify() in online_pages() will be called several times against
    > a section.
    >

    It seems the only in-tree user of the notifier is mm/slub.c, and it only
    cares about MEM_GOING_ONLINE, GOING_OFFLINE, OFFLINE and CANCEL_ONLINE
    (not ONLINE or CANCEL_OFFLINE).

    Also,

    if (onlined_pages)
    memory_notify(MEM_ONLINE, &arg);

    doesn't seem correct, because arg.nr_pages still has the original
    nr_pages, and not the number of pages actually onlined (onlined_pages).
    Also arg.start_pfn isn't terribly meaningful if a discontiguous set of
    pages can be actually onlined.

    J


    \
     
     \ /
      Last update: 2008-03-28 22:33    [W:0.043 / U:30.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site