Messages in this thread | | | Date | Fri, 28 Mar 2008 09:26:19 -0400 | From | "Bob Copeland" <> | Subject | Re: [PATCH 5/7] omfs: add bitmap routines |
| |
On Thu, Mar 27, 2008 at 11:51 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Thursday 27 March 2008, Bob Copeland wrote: > > > +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0}; > > + > > +unsigned long omfs_count_free(struct super_block *sb) > > I think it would be helpful to express this using hweight64.
Thanks for the review.
Yes, that would probably be cleaner. FWIW minix and affs both have this sort of code too.
-Bob
| |