lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [git pull] x86 fixes

    * Harvey Harrison <harvey.harrison@gmail.com> wrote:

    > -#ifdef CONFIG_X86_32
    > /* Catch an obscure case of prefetch inside an NX page: */
    > - if ((__supported_pte_mask & _PAGE_NX) && (error_code & 16))
    > - return 0;
    > -#endif
    > -
    > - /* If it was a exec fault on NX page, ignore */
    > - if (error_code & PF_INSTR)
    > + if ((__supported_pte_mask & _PAGE_NX) && (error_code & PF_INSTR))
    > return 0;

    heh, did the exact same cleanup :)

    i suspect we would be fine with a simple:

    if (error_code & PF_INSTR)
    return 0;

    because if we get a fault on an instruction fetch then it clearly cannot
    be a prefetch erratum ... The NX condition simply comes from a cautious
    32-bit workaround. (on 64-bit we always have NX - at least on AMD which
    has this erratum.)

    and thus the currently pulled code is not incorrect, just ugly and
    nonsensical.

    Ingo


    \
     
     \ /
      Last update: 2008-03-27 21:59    [W:0.024 / U:120.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site