Messages in this thread | | | Date | Thu, 27 Mar 2008 13:37:31 +0100 | From | Roel Kluin <> | Subject | Re: [PATCH v2] likeliness accounting cleanup |
| |
Roel Kluin wrote: > Store __builtin_return_address (caller) rather than __func__ in likeliness > struct. 'line' and 'type' are combined in 'label' > > +/- now denotes whether expectation fails in less than 5% of the tests - rather > than whether more unexpected than expected were encountered. The function at > the displayed filename & line and the caller are not necessarily the same. > A few more Likely Profiling Results changes were made. > > struct seq_operations becomes static, unsigned ints true and false (shadowed) > are replaced by pos and neg. > --- > New layout: > > Likely Profiling Results > -------------------------------------------------------------------- > [+- ]Type | # True | # False | Function@Filename:Line > unlikely | 0| 32082| fget+0xd0/0x1d0@include/asm/arch/atomic_32.h:235 > > Compiles and runs here. Thanks for previous comments. > > include/linux/compiler.h | 16 ++++++++-------- > lib/likely_prof.c | 45 +++++++++++++++++++++++++-------------------- > 2 files changed, 33 insertions(+), 28 deletions(-) >
This should be applied after the -mm patches: http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/profile-likely-unlikely-macros.patch http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/profile-likely-unlikely-macros-fix.patch
Also I forgot to add a signoff, so here it is:
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
| |