Messages in this thread | | | Date | Thu, 27 Mar 2008 13:08:50 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH -mm 1/4] x86_64 boot: Add free_early to early reservation machanism |
| |
On Thu, Mar 27, 2008 at 12:58:51PM +0100, Ingo Molnar wrote: > > * Paul Jackson <pj@sgi.com> wrote: > > > Huang wrote: > > > + panic("free_early on not reserved area: %lx-%lx!", start, end); > > > > Should that be 'early_panic', not 'panic' ? > > > > (I see a couple more panics in that file, which I wonder > > if should be early_panic as well ?) > > this should be fixed properly btw: panic() should self-select whether it > does an early_panic() or a real panic().
There's also need of a EARLY_BUG, but self selection would be a little tricky here.
I still have an old patch for this, but I haven't gotten around to submit it because it turned out the first user of it wasn't a good idea.
-Andi
| |