lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] allow arch specific function for allocating gigantic pages

    Haven't reviewed it in detail, just noticed something.

    > @@ -614,6 +610,7 @@ static int __init hugetlb_init(void)
    > {
    > if (HPAGE_SHIFT == 0)
    > return 0;
    > + INIT_LIST_HEAD(&huge_boot_pages);
    > return hugetlb_init_hstate(&global_hstate);

    I don't think adding the INIT_LIST_HEAD here is correct. There can
    be huge pages added by the __setup handlers before hugetlb_init

    -Andi


    \
     
     \ /
      Last update: 2008-03-26 22:49    [W:0.028 / U:30.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site