Messages in this thread | | | Date | Wed, 26 Mar 2008 11:58:39 -0500 | From | Dean Nelson <> | Subject | Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl |
| |
On Wed, Mar 26, 2008 at 10:03:36AM +0000, Andy Whitcroft wrote: > On Tue, Mar 25, 2008 at 03:05:17PM -0500, Dean Nelson wrote: > > Gah, who ever came up with that syntax. Yep, thats a falsie. Should be > fixed in the latest version: > > http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-next > > Thanks for the report.
You're welcome and thanks for the quick fix to checkpatch.pl. I used the new version and it fixed the problem except for ones that were of the following form:
enum xp_retval (*xp_set_amo_with_interrupt) (u64 *amo_va, int op, u64 operand, int remote, int nasid, int phys_cpuid, int vector); EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);
which still generated the false positive:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #70: FILE: misc/xp/xp_main.c:70: +EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);
Thanks, Dean
| |