[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 01/10] x86_64: Cleanup non-smp usage of cpu maps v2
    Ingo Molnar wrote:
    > * Mike Travis <> wrote:
    >> Cleanup references to the early cpu maps for the non-SMP configuration
    >> and remove some functions called for SMP configurations only.
    > thanks, applied.
    > one observation:
    >> +#ifdef CONFIG_SMP
    >> extern int x86_cpu_to_node_map_init[];
    >> extern void *x86_cpu_to_node_map_early_ptr;
    >> +#else
    >> +#define x86_cpu_to_node_map_early_ptr NULL
    >> +#endif
    > Right now all these early_ptrs are in essence open-coded "early
    > per-cpu", right? But shouldnt we solve that in a much cleaner way: by
    > explicitly adding an early-per-cpu types and accessors, and avoid all
    > that #ifdeffery?
    > Ingo

    I was thinking of something similar but had to put it on the back
    burner until we got to the point of being able to boot a kernel
    with NR_CPUS set to 4096. It should pop back up on the priority
    queue very soon... ;-)


     \ /
      Last update: 2008-03-26 17:15    [W:0.022 / U:2.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site