Messages in this thread | | | Subject | ohci : strange looking use of round_jiffies_relative. possible bug ? | From | Richard Kennedy <> | Date | Wed, 26 Mar 2008 14:38:09 +0000 |
| |
I was looking at the uses of round_jiffies and noticed that the ohci unlink_watchdog_func() calls mod_timer(&ohci->unlink_watchdog, round_jiffies_relative(HZ));
Which looks a bit strange as it will set the timer to 0 <= t < HZ. Reading the comments I think that is really is expecting to setup timer to (now + 1s)
mod_timer(&ohci->unlink_watchdog, round_jiffies(jiffies + HZ));
If this is not true then perhaps it needs a comment to explain what it _is_ trying to do, because it's got me baffled ;)
Cheers Richard
| |