Messages in this thread | | | Date | Tue, 25 Mar 2008 18:00:14 +0000 | From | Al Viro <> | Subject | Re: [git pull] vfs patches |
| |
On Tue, Mar 25, 2008 at 09:05:59AM -0700, Linus Torvalds wrote:
> dget(save.dentry); > mntget(save.mnt); > ... > path_put(&save); > > which looks very strange compared to the natural sequence: > > path_get(&save); > .. > path_put(&save); > > and yes, I realize the code was just moved (and the reason for the mixing > is that the "path_put()" conversion was done much more aggressively, as > the ordering matters), but I'm bringing this up in the hope somebody has > the energy to clean things like up some day...
*nod*
Keep in mind that there's a lot more coming post-.25; FWIW, there's another bunch of patches that probably ought to go before .25 (mount expiry stuff; I'll do a bit of reordering and probably ask to pull tomorrow).
The next couple of cycles is going to get interesting around fs/{namei,namespace,pnode,super,dentry}.c
| |