Messages in this thread | | | Date | Tue, 25 Mar 2008 19:00:06 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 0/5] Generic smp_call_function(), improvements, and smp_call_function_single() |
| |
On Tue, Mar 25 2008, Luck, Tony wrote: > > So now I/we just need to figure out why the hack to call > > init_call_single_data() is needed. You seem to imply it was being called > > too late, I thought perhaps too early. Where did you stick the > > init_call_single_data() call in? > > In ia64 the first calls to smp_call_function_single() are made > while bringing up other cpus ... which happens from: > > kernel_init() > smp_init() > > The init calls are made a few lines later (still in kernel_init): > > do_basic_setup() > do_initcalls() > > I moved the call radically earlier (before sched_init() in > init/main.c:start_kernel()) just to be sure, but that was > overkill. > > Perhaps making the call from do_pre_smp_initcalls() is the > logical place? Like this (though purists will say that the > extern declaration should be in some header file):
It looks fine to me, not a big deal I think... I was woried that core_initcall() would not suit all, so this helps.
Thanks Tony!
-- Jens Axboe
| |