Messages in this thread | | | Date | Mon, 24 Mar 2008 23:46:31 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit |
| |
On Mon, Mar 24, 2008 at 02:43:16PM +0000, Adrian McMenamin wrote: > On Mon, 2008-03-24 at 15:10 +0100, J??rn Engel wrote: > > On Mon, 24 March 2008 13:58:40 +0000, Adrian McMenamin wrote: > > > > > > Tempting as it is to continue the war, discretion will be the better > > > part of valour here and I will give you the last word. > > > > > > Of course I don't mind you sending patches. Indeed it would be very > > > helpful and generous of you to do so. > > > > Good. The first four shouldn't change any behaviour. Number five flips > > positive error returns into negative ones. I believe the old behaviour > > is a bug. Worth a second look to make sure. > > > > All five patches are attached. Hope that doesn't cause any problems. > > Well, I haven't got round to applying them and testing them yet, though > they look ok, obviously, except for one thing: I'm pretty much where you > are on the goto versus return thing, but got pretty clear instructions > on a previous patch from Andrew Morton that using gotos to ensure > functions limit the number of return points is the way to go. > The gotos help clean up the error path when you have something to do. In this case there's nothing going on but a NULL return, so it really doesn't matter one way or the other. Most people tend to avoid the goto if you really have nothing to do in an error path.
| |