lkml.org 
[lkml]   [2008]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] time: xtime lock vs printk
    From
    Date

    On Mon, 2008-03-24 at 13:24 +0100, Peter Zijlstra wrote:
    > - printk(KERN_INFO "Time: %s clocksource has been installed.\n",
    > + /*
    > + * We're holding xtime lock and waking up klogd would deadlock
    > + * us on enqueue. Print without waking.
    > + */
    > + printk_nowakeup(KERN_INFO "Time: %s clocksource has been
    > installed.\n",
    > clock->name);

    It doesn't seem like there is a lot of potential for more xtime write
    lock holders to do printk's .. We could just remove this line, or move
    this printk into an __init ..

    Daniel



    \
     
     \ /
      Last update: 2008-03-24 15:25    [W:0.020 / U:61.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site