[lkml]   [2008]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit
    [Recipient list cut somewhat]

    On Mon, 2008-03-24 at 11:08 +0900, Paul Mundt wrote:
    > On Sat, Mar 22, 2008 at 06:39:07PM +0000, Adrian McMenamin wrote:
    > > On Sat, 2008-03-22 at 19:32 +0100, J??rn Engel wrote:

    > > > I don't mind merging code that isn't up to our standards yet. But I
    > > > have a bad feeling about a maintainer that does not understand
    > > > review comments. Since you had similar problems understanding
    > > > Andrew, part of the blame may sit on your side.
    > >
    > > I'm sorry that you feel that way, but as you took the hump when I said
    > > that this:
    > >
    > > "Possibly the big-endian annotations need to trickly though the layers
    > > here as well."
    > >
    > > Isn't good english (and it's not) and asked you - twice - to explain
    > > what you meant. I cannot accept your summary.
    > >
    > Just as there's no motivation for others to accept merging your code. You
    > really need to work on handling feedback in a less oppositional way if
    > you ever want to have your changes merged.
    > As far as "good" english goes, this is l-k, hang your degree at the
    > door and get off your high horse. Even the native speakers perform
    > horrendous atrocities against the english language, that's life, deal
    > with it. In technical discussions this doesn't tend to matter at all, as
    > long as the meaning is obvious -- which in this case it certainly seems
    > to be. If you're speaking a different language, perhaps it's a
    > miscommunication or misinterpretation of technical terms rather than
    > anything else. Do not automatically assume the blame lies with people who
    > are trying to help you.

    I have no desire to have a flame war over this. But I didn't understand
    the sentence, was told twice that I should act on it and asked twice
    simply what it meant. Eg the second time...

    "I'm sorry, but the comment above <snap> isn't good english. What do you

    Not unreasonable I think. After the second time I was told all
    communication would cease. And, yes, that did annoy me, especially when
    the next thing I get is someone telling me I didn't listen to them.

    I certainly don't expect people to be flawless speakers or writers of
    English. But I don't think it is wrong to ask for clarity when something
    that doesn't make sense is written.

    Bluntly I almost always think the blame lies with me when people point
    out mistakes or imperfections in my code - because it usually is. But I
    don't think it is unreasonable to ask what people mean.

     \ /
      Last update: 2008-03-24 13:09    [W:0.024 / U:35.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site