lkml.org 
[lkml]   [2008]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch 02/13] x86: PAT infrastructure patch
On Wed, Mar 19, 2008 at 01:06:39PM -0700, Randy Dunlap wrote:
> On Tue, 18 Mar 2008 17:00:14 -0700 venkatesh.pallipadi@intel.com wrote:
>
> diffstat would be very nice to have.

I have updated my quilt scripts to auto-generate diffstat for any future
patches.

>
>
> > Index: linux-2.6-x86.git/arch/x86/Kconfig
> > ===================================================================
> > --- linux-2.6-x86.git.orig/arch/x86/Kconfig 2008-03-17 11:06:47.000000000 -0700
> > +++ linux-2.6-x86.git/arch/x86/Kconfig 2008-03-17 11:06:51.000000000 -0700
> > @@ -1013,6 +1013,21 @@
> >
> > See <file:Documentation/mtrr.txt> for more information.
> >
> > +config X86_PAT
> > + def_bool y
> > + prompt "x86 PAT support"
> > + depends on MTRR && NONPROMISC_DEVMEM
> > + help
> > + Use PAT attributes to setup page level cache control.
> > + ---help---
> > + PATs are the modern equivalents of MTRRs and are much more
> > + flexible than MTRRs.
> > +
>
> Do 2 help sections actually work? We don't usually do that.
> Just change the second one to a blank line.
>
> > + Say N here if you see bootup problems (boot crash, boot hang,
> > + spontaneous reboots) or a non-working Xorg.
>
> Maybe "a non-working Xorg video driver" ?
> or even omit Xorg and just say video driver?
>

Done with below patch.
Ingo: Please apply.

Thanks,
Venki




Fix double help section in PAT Kconfig. Thanks to Randy Dunlap for catching
this bug.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

---
arch/x86/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6-x86.git/arch/x86/Kconfig
===================================================================
--- linux-2.6-x86.git.orig/arch/x86/Kconfig 2008-03-21 08:28:47.000000000 -0700
+++ linux-2.6-x86.git/arch/x86/Kconfig 2008-03-24 07:19:35.000000000 -0700
@@ -1019,12 +1019,12 @@ config X86_PAT
depends on MTRR && NONPROMISC_DEVMEM
help
Use PAT attributes to setup page level cache control.
- ---help---
+
PATs are the modern equivalents of MTRRs and are much more
flexible than MTRRs.

Say N here if you see bootup problems (boot crash, boot hang,
- spontaneous reboots) or a non-working Xorg.
+ spontaneous reboots) or a non-working video driver.

If unsure, say Y.


\
 
 \ /
  Last update: 2008-03-24 22:25    [W:0.056 / U:2.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site