Messages in this thread | | | Date | Mon, 24 Mar 2008 16:57:38 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] add random irq flag to natsemi network driver |
| |
James Simmons wrote: > Please apply this patch. On the embbeded board I work on this is the only > entropy source we have. > > diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c > index 385f69c..c6553dd 100644 > --- a/drivers/net/natsemi.c > +++ b/drivers/net/natsemi.c > @@ -1529,7 +1529,8 @@ static int netdev_open(struct net_device *dev) > /* Reset the chip, just in case. */ > natsemi_reset(dev); > > - i = request_irq(dev->irq, &intr_handler, IRQF_SHARED, dev->name, dev); > + i = request_irq(dev->irq, &intr_handler, IRQF_SHARED | IRQF_SAMPLE_RANDOM, > + dev->name, dev);
With timed interrupt mitigation and remotely controlled interrupt sources, this can be distinctly non-random.
This type of patch is traditionally not applied...
Jeff
| |