Messages in this thread | | | From | Mike Frysinger <> | Subject | Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet) | Date | Mon, 24 Mar 2008 12:57:56 -0400 |
| |
On Monday 24 March 2008, Randy Dunlap wrote: > On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote: > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > > --- > > Documentation/DocBook/Makefile | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/Documentation/DocBook/Makefile > > b/Documentation/DocBook/Makefile index 300e170..f6a4ba3 100644 > > --- a/Documentation/DocBook/Makefile > > +++ b/Documentation/DocBook/Makefile > > @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@ > > > > ### > > # Rule to convert a .c file to inline XML documentation > > + gen_xml = : > > + quiet_gen_xml = echo ' GEN $@' > > +silent_gen_xml = : > > %.xml: %.c > > - @echo ' GEN $@' > > + @$($(quiet)gen_xml) > > @( \ > > echo "<programlisting>"; \ > > expand --tabs=8 < $< | \ > > -- > > The Makefile changes are good, but the patch description makes it > appear that Mike was rushed. How about something like this?
i just copied & pasted the previous commit messages for similar fixes. your longer version sounds fine to me though. -mike [unhandled content-type:application/pgp-signature] | |