lkml.org 
[lkml]   [2008]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 4/8] ide: remove obsoleted "hdx=autotune" kernel parameter
    * Remove obsoleted "hdx=autotune" kernel parameter
    (we always auto-tune PIO if possible nowadays).

    * Remove no longer needed ide_drive_t.autotune flag.

    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    ---
    Documentation/ide/ide.txt | 7 -------
    drivers/ide/ide-probe.c | 4 +---
    drivers/ide/ide.c | 5 +----
    include/linux/ide.h | 1 -
    4 files changed, 2 insertions(+), 15 deletions(-)

    Index: b/Documentation/ide/ide.txt
    ===================================================================
    --- a/Documentation/ide/ide.txt
    +++ b/Documentation/ide/ide.txt
    @@ -196,13 +196,6 @@ Summary of ide driver parameters for ker

    "hdx=cyl,head,sect" : disk drive is present, with specified geometry

    - "hdx=autotune" : driver will attempt to tune interface speed
    - to the fastest PIO mode supported,
    - if possible for this drive only.
    - Not fully supported by all chipset types,
    - and quite likely to cause trouble with
    - older/odd IDE drives.
    -
    "hdx=nodma" : disallow DMA

    "ide=doubler" : probe/support IDE doublers on Amiga
    Index: b/drivers/ide/ide-probe.c
    ===================================================================
    --- a/drivers/ide/ide-probe.c
    +++ b/drivers/ide/ide-probe.c
    @@ -826,8 +826,7 @@ static void ide_port_tune_devices(ide_hw
    ide_drive_t *drive = &hwif->drives[unit];

    if (drive->present) {
    - if (drive->autotune)
    - ide_set_max_pio(drive);
    + ide_set_max_pio(drive);

    drive->nice1 = 1;

    @@ -1324,7 +1323,6 @@ static void ide_port_init_devices(ide_hw
    drive->unmask = 1;
    if (hwif->host_flags & IDE_HFLAG_NO_UNMASK_IRQS)
    drive->no_unmask = 1;
    - drive->autotune = 1;
    }

    if (port_ops && port_ops->port_init_devs)
    Index: b/drivers/ide/ide.c
    ===================================================================
    --- a/drivers/ide/ide.c
    +++ b/drivers/ide/ide.c
    @@ -851,7 +851,7 @@ static int __init ide_setup(char *s)
    if (s[0] == 'h' && s[1] == 'd' && s[2] >= 'a' && s[2] <= max_drive) {
    const char *hd_words[] = {
    "none", "noprobe", "nowerr", "cdrom", "nodma",
    - "autotune", "-7", "-8", "-9", "-10",
    + "-6", "-7", "-8", "-9", "-10",
    "noflush", "remap", "remap63", "scsi", NULL };
    unit = s[2] - 'a';
    hw = unit / MAX_DRIVES;
    @@ -879,9 +879,6 @@ static int __init ide_setup(char *s)
    case -5: /* nodma */
    drive->nodma = 1;
    goto done;
    - case -6: /* "autotune" */
    - drive->autotune = 1;
    - goto obsolete_option;
    case -11: /* noflush */
    drive->noflush = 1;
    goto done;
    Index: b/include/linux/ide.h
    ===================================================================
    --- a/include/linux/ide.h
    +++ b/include/linux/ide.h
    @@ -322,7 +322,6 @@ typedef struct ide_drive_s {
    unsigned atapi_overlap : 1; /* ATAPI overlap (not supported) */
    unsigned doorlocking : 1; /* for removable only: door lock/unlock works */
    unsigned nodma : 1; /* disallow DMA */
    - unsigned autotune : 1; /* 0=default, 1=autotune */
    unsigned remap_0_to_1 : 1; /* 0=noremap, 1=remap 0->1 (for EZDrive) */
    unsigned blocked : 1; /* 1=powermanagment told us not to do anything, so sleep nicely */
    unsigned vdma : 1; /* 1=doing PIO over DMA 0=doing normal DMA */

    \
     
     \ /
      Last update: 2008-03-22 22:55    [W:0.022 / U:95.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site