Messages in this thread | | | Date | Fri, 21 Mar 2008 10:53:11 +0100 | From | Jean Delvare <> | Subject | Re: use of preempt_count instead of in_atomic() at leds-gpio.c |
| |
On Thu, 20 Mar 2008 20:17:23 -0700, Andrew Morton wrote: > in_atomic() is for core kernel use only. (...)
Then why is it made available to drivers through <linux/hardirq.h>? If it's such a dangerous macro to call from drivers, it shouldn't be made available, or at the very least there should be a big fat warning in <linux/hardirq.h> that drivers aren't supposed to use it. This would have avoided the 23 uses cases in drivers we have right now.
-- Jean Delvare
| |