Messages in this thread | | | Date | Fri, 21 Mar 2008 15:26:35 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API |
| |
On Fri, Mar 21, 2008 at 04:27:12PM -0500, James Bottomley wrote: > We have a problem in scsi_transport_spi in that we need to customise > not only the visibility of the attributes, but also their mode. Fix > this by making the is_visible() callback return a mode, with 0 > indicating is not visible. > > Also add a sysfs_update_group() API to allow us to change either the > visibility or mode of the files at any time on the fly. > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> > --- > > Greg, can I take this through SCSI, please ... assuming it's OK? We > need this to fix up the SPI transport class.
Sure. But can you document that "update" field a bit more so we can remember what it means in the future?
thanks,
greg k-h
| |