lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [SCSI] fix media change events for polled devices
From
Date
On Fri, 2008-03-21 at 10:31 -0700, Linus Torvalds wrote:
>
> On Fri, 21 Mar 2008, Jeff Garzik wrote:
> >
> > And that is the fix -- initialize supported_events according to sr/sd's needs,
> > and revert this change (4d1566ed2100d074ccc654e5cf2e44cdea3a01d0) as obviously
> > broken.
>
> Patches, please? I can do the revert, but the patch to supported_events
> and the testing, please?

I tested this and discussed it with Kristen before it went in. The
current fix you sucked in with scsi-rc-fixes basically makes the whole
lot work for 2.6.25 (both AN media change events and traditional polled
ones). The thing that doesn't work is the ability to turn off AN events
from user space, but that feature never worked anyway.

I promised Kay I'd work on a better solution for 2.6.26 which will
include separating up the input events into polled and AN for a CD but
emitting the same media change event to udev at the top (so you can rely
on either polled or AN for media change and select which or both if you
desire).

James




\
 
 \ /
  Last update: 2008-03-21 20:41    [from the cache]
©2003-2011 Jasper Spaans