lkml.org 
[lkml]   [2008]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 11/17] ide-tape: remove pipeline-specific code from idetape_setup
Date

On Monday 17 March 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>

->max_stages and ->{min,max}_pipeline are later removed in patch #14,
it makes sense to merge both patches together [ as I did ;-) ]

[...]

> - if (tape->max_stages == 0) {
> - tape->max_stages = 1;
> - tape->min_pipeline = 1;
> - tape->max_pipeline = 1;
> - }
> -
> - t1 = (tape->stage_size * HZ) / (speed * 1000);
> - tmid = (*(u16 *)&tape->caps[16] * 32 * HZ) / (speed * 125);
> - tn = (IDETAPE_FIFO_THRESHOLD * tape->stage_size * HZ) / (speed * 1000);
> -
> - if (tape->max_stages)
> - t = tn;
> - else
> - t = t1;
> + t = (tape->stage_size * HZ) / (speed * 1000);

tape->max_stages was always > 0 so 't' should use 'tn' not 't1'
(fixed during merge)


\
 
 \ /
  Last update: 2008-03-21 01:03    [W:0.916 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site