lkml.org 
[lkml]   [2008]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] kernel: add byteorder macros with alignment fixups
On Thu, Mar 20, 2008 at 11:37:24AM -0700, Harvey Harrison wrote:
> On Thu, 2008-03-20 at 18:29 +0000, Al Viro wrote:
> > On Thu, Mar 20, 2008 at 10:34:14AM -0700, Harvey Harrison wrote:
> > > A common pattern in the kernel (especially networking) is:
> > >
> > > le32_to_cpu(get_unaligned((__le32 *)x));
> > >
> > > Repeat for various combinations of le/be and 64/32/16 bit. Add
> > > a variant that operates on possibly unaligned pointers to
> > > byteorder/generic.h
> >
> > ... and asm/unaligned.h has just acquired fuckloads of places including
> > it indirectly. Not Nice(tm).
>
> Time for linux/unaligned.h?

Er... And just how would that improve things?


\
 
 \ /
  Last update: 2008-03-20 20:13    [W:0.059 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site