[lkml]   [2008]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 6/6] USB: enable USB-PERSIST by default
Alan Stern wrote:
> What difference in meaning do you imagine replacing
> "This" with "That" would achieve?

It might achieve a more understandable change log,
which then aids others in deciding whether what you
meant for the code to do, is what the code actually does.

And it appears to have worked in this case,
as you have now published a more complete description of intent.


>>> This approach has the advantage of giving the user the ability to turn
>>> off USB-PERSIST for devices with mounted filesystems, rather than
>>> making the kernel always assume it should be on.
>> ...
> What I meant (it probably wasn't very clear from the text) was that the
> approach of leaving USB-PERSIST controlled by the power/persist
> attribute and merely altering the attribute's default value is better
> than having the kernel unilaterally and unconditionally turn
> USB-PERSIST on for every device holding a mounted filesystem. In other
> words, the approach taken by the patch is better than the approach
> suggested by Linus Torvalds.
> Alan Stern

 \ /
  Last update: 2008-03-20 15:19    [W:0.047 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site