lkml.org 
[lkml]   [2008]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] Fix misuse of wakeup flag accessors in serial core
    Date
    From: Alan Stern <stern@rowland.harvard.edu>

    This patch (as1059) fixes a mistake in the way the serial core
    initializes a device's wakeup settings. It should use the accessor
    routine instead of relying on a macro producing an lvalue.

    Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    ---

    Index: usb-2.6/drivers/serial/serial_core.c
    ===================================================================
    --- usb-2.6.orig/drivers/serial/serial_core.c
    +++ usb-2.6/drivers/serial/serial_core.c
    @@ -2356,7 +2356,7 @@ int uart_add_one_port(struct uart_driver
    */
    tty_dev = tty_register_device(drv->tty_driver, port->line, port->dev);
    if (likely(!IS_ERR(tty_dev))) {
    - device_can_wakeup(tty_dev) = 1;
    + device_init_wakeup(tty_dev, 1);
    device_set_wakeup_enable(tty_dev, 0);
    } else
    printk(KERN_ERR "Cannot register tty device on line %d\n",




    \
     
     \ /
      Last update: 2008-03-20 00:15    [W:0.040 / U:62.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site