Messages in this thread | | | Date | Tue, 18 Mar 2008 18:14:39 -0500 | From | serge@hallyn ... | Subject | Re: [PATCH] signals: check_kill_permission: check session under tasklist_lock |
| |
Quoting Oleg Nesterov (oleg@tv-sign.ru): > On 03/18, serge@hallyn.com wrote: > > > > Quoting Oleg Nesterov (oleg@tv-sign.ru): > > > --- 25/security/commoncap.c~CKP_TAKE_TASKLIST 2008-03-18 17:07:02.000000000 +0300 > > > +++ 25/security/commoncap.c 2008-03-18 17:21:10.000000000 +0300 > > > @@ -552,10 +552,6 @@ int cap_task_kill(struct task_struct *p, > > > if (p->uid == current->uid) > > > return 0; > > > > > > - /* sigcont is permitted within same session */ > > > - if (sig == SIGCONT && (task_session_nr(current) == task_session_nr(p))) > > > - return 0; > > > - > > > if (secid) > > > /* > > > * Signal sent as a particular user. > > > > Note that cap_task_kill() should be gone anyway. What tree were you > > basing this on? > > Ah. I realy hoped that cap_task_kill() was already killed. And I googled > this patch: http://marc.info/?l=linux-kernel&m=120422062515386 > > But I checked 2.6.25-rc5-mm1.bz2, it is still here. And I didn't find > anything related in http://userweb.kernel.org/~akpm/mmotm/. I even checked > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=security/commoncap.c > > So, is it still here or killed? If it is dead - great ;)
Hmm, I thought it had been pulled in. I don't see it. I'll re-spin and re-send against -mm, -stable, and -git.
thanks, -serge
| |