Messages in this thread | | | Date | Tue, 18 Mar 2008 18:15:55 +0900 (JST) | Subject | Re: [PATCH] [IPV6] remove unused parameter (struct sock parameter) from ip6_route_output() | From | YOSHIFUJI Hideaki / 吉藤英明 <> |
| |
NAK; I have a plan to use it in net-2.6.26 tree.
--yoshfuji
In article <eb3ff54b0803180203h18cda4ceja6ae28033638d338@mail.gmail.com> (at Tue, 18 Mar 2008 11:03:04 +0200), "Rami Rosen" <ramirose@gmail.com> says:
> Hi, > This patch removes the struct sock parameter from ip6_route_output(); > looking at the ip6_route_output() implementation in net/ipv6/route.c > will show immediately that it is not used in this method. > > In fact, icmp.c and ip6_output.c are the only places in the kernel > where the sk (struct sock) parameter passed to ip6_route_output() is not NULL; > anyhow, as explained above, this parameter is unused; changing > the ip6_route_output() prototype by omitting the struct sock parameter > does not break anything. > > > Regards, > Rami Rosen > > > Signed-off-by: Rami Rosen <ramirose@gmail.com>
| |