Messages in this thread | | | Subject | Re: [patch 3/8] mm: rotate_reclaimable_page() cleanup | From | Peter Zijlstra <> | Date | Tue, 18 Mar 2008 12:31:36 +0100 |
| |
On Mon, 2008-03-17 at 20:19 +0100, Miklos Szeredi wrote: > plain text document attachment (rotate_reclaimable_page_cleanup.patch) > From: Miklos Szeredi <mszeredi@suse.cz> > > Clean up messy conditional calling of test_clear_page_writeback() from > both rotate_reclaimable_page() and end_page_writeback().
> -int rotate_reclaimable_page(struct page *page) > +void rotate_reclaimable_page(struct page *page) > { > - struct pagevec *pvec; > - unsigned long flags; > - > - if (PageLocked(page)) > - return 1; > - if (PageDirty(page)) > - return 1; > - if (PageActive(page)) > - return 1; > - if (!PageLRU(page)) > - return 1;
Might be me, but I find the above easier to read than
> + if (!PageLocked(page) && !PageDirty(page) && !PageActive(page) && > + PageLRU(page)) { >
| |