lkml.org 
[lkml]   [2008]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 3/8] mm: rotate_reclaimable_page() cleanup
From
Date
On Mon, 2008-03-17 at 20:19 +0100, Miklos Szeredi wrote:
> plain text document attachment (rotate_reclaimable_page_cleanup.patch)
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Clean up messy conditional calling of test_clear_page_writeback() from
> both rotate_reclaimable_page() and end_page_writeback().

> -int rotate_reclaimable_page(struct page *page)
> +void rotate_reclaimable_page(struct page *page)
> {
> - struct pagevec *pvec;
> - unsigned long flags;
> -
> - if (PageLocked(page))
> - return 1;
> - if (PageDirty(page))
> - return 1;
> - if (PageActive(page))
> - return 1;
> - if (!PageLRU(page))
> - return 1;

Might be me, but I find the above easier to read than

> + if (!PageLocked(page) && !PageDirty(page) && !PageActive(page) &&
> + PageLRU(page)) {
>





\
 
 \ /
  Last update: 2008-03-18 12:35    [W:0.121 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site