Messages in this thread | | | Date | Mon, 17 Mar 2008 00:53:43 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator |
| |
On Mon, Mar 17, 2008 at 12:41 AM, Andi Kleen <andi@firstfloor.org> wrote: > > when node_boot_start is 512M alignment, and align is 1024M, offset > > could be 512M. it seems > > i = ALIGN(i, incr) need to do sth with offset... > > It's possible that there are better fixes for this, but at least > my simple patch seems to work here. I admit I was banging my > head against this for some time and when I did the fix I just > wanted the bug to go away and didn't really go for subtleness. > > The bootmem allocator is quite spaghetti in fact, it could > really need some general clean up (although it's' not quite > as bad yet as page_alloc.c)
i = ALIGN(i+offset, incr) - offset;
also the one in fail_block...
only happen when align is large than alignment of node_boot_start.
YH
| |