lkml.org 
[lkml]   [2008]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [11/18] Fix alignment bug in bootmem allocator
On Mon, Mar 17, 2008 at 12:17 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
> On Mon, Mar 17, 2008 at 12:02 AM, Andi Kleen <andi@firstfloor.org> wrote:
> > > node_boot_start is not page aligned?
> >
> > It is, but it is not necessarily GB aligned and without this
> > change sometimes alloc_bootmem when requesting GB alignment
> > doesn't return GB aligned memory. This was a nasty problem
> > that took some time to track down.
>
> or preferred has some problem?
>
>
> preferred = PFN_DOWN(ALIGN(preferred, align)) + offset;
>

when node_boot_start is 512M alignment, and align is 1024M, offset
could be 512M. it seems
i = ALIGN(i, incr) need to do sth with offset...

YH


\
 
 \ /
  Last update: 2008-03-17 08:33    [from the cache]
©2003-2011 Jasper Spaans