Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] fix verify_export_symbols() | Date | Tue, 18 Mar 2008 11:29:32 +1100 |
| |
On Tuesday 18 March 2008 09:36:04 Rusty Russell wrote: > On Thursday 13 March 2008 20:04:17 you wrote: > > When the newer export flavors were added, it was apparently forgotten > > to add respective code here. > > In order to not double the (source) size of the function, add some > > abstraction to reduce code duplication. > > Hi Jan, > > Actually, the others did exist, they just weren't checked.
No, my bad, you're right (GPL-only existed, but they were covered already). The problem with this is that we'll get a bogus unused warning in the case of doing a __find_symbol on an unused symbol.
It's time for a general cleanup of the __find_symbol logic. I'll post when it's done.
Thanks! Rusty.
| |